Display Link as payment method on order received page with setup intents #8764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
brettshumaker
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
mdmoore
commented
May 3, 2024
Comment on lines
-3433
to
-3436
| $payment_method_id = isset( $_POST['payment_method_id'] ) ? wc_clean( wp_unslash( $_POST['payment_method_id'] ) ) : ''; | ||
| if ( 'null' === $payment_method_id ) { | ||
| $payment_method_id = ''; | ||
| } |
There was a problem hiding this comment.
update_order_status() is used to update 3DS orders after authentication. Shortcode checkout includes payment_method_id in the update_order_status() AJAX request for setup intents but blocks checkout doesn't. This payment method is only used in adding the token to the user. We need the token to determine the payment method type in order to correctly set the payment method title. This is all to say that we can safely remove this as it's now being set below, pulled from the intent.
Incidentally, this might solve #8611 but I haven't had a chance to verify that yet.
brettshumaker
approved these changes
May 3, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8122
Changes proposed in this Pull Request
This PR ensures that Link, rather than Credit / Debit Card, is displayed as the payment method on the order received page for Link orders using setup intents. The problem is that the payment method type,
cardorlink, is pulled from thepayment_method_detailsobject within the intent. Setup intents don't containpayment_method_detailsso the payment method type is pulled frompayment_method_options, which only containscard. To get around this, we can look at the token and determine if it's a Link token and set the payment method type accordingly.Testing instructions
This specifically deals with setup intents so assume all orders should be setup intents, such as a subscription with a free trial.
Repeat the following steps on Shortcode and Blocks checkouts:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge